web2project: web-based project management

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0000321 [v1.2 Release (Closed)] Files minor always 2009-12-01 10:11 2009-12-08 21:02
Reporter madumlao View Status public  
Assigned To caseydk
Priority normal Resolution fixed  
Status closed   Product Version
Summary 0000321: web2project files uploading demands 777 permissions when it could do with less
Description in modules/files/addedit.php, the line that checks whether web2project can write to the files dir demands the files dir to have 777 permissions. This is not necessary and exposes the files dir to read/write access by other users on the server.
Additional Information The preferred way to do this is using the php is_writable/readable/executable() functions on the files directory, because this directly tests the application'saccess, rather than indirectly compares the directory's permissions. 777 should be avoided when possible.

Attached file just swaps out the long permission check in adedit.php with an is_writable call.
Tags No tags attached.
Attached Files ? file icon addedit.php.diff [^] (1,073 bytes) 2009-12-01 10:11

- Relationships

-  Notes
(0000617)
caseydk (administrator)
2009-12-01 11:30

Awesome, you're my hero.

I've been concerned about this one but haven't been able to get to it. I'll review this one and merge/offer feedback asap.
(0000618)
caseydk (administrator)
2009-12-02 16:37

Resolved as described in r827;

- Issue History
Date Modified Username Field Change
2009-12-01 10:11 madumlao New Issue
2009-12-01 10:11 madumlao File Added: addedit.php.diff
2009-12-01 10:18 madumlao Issue Monitored: madumlao
2009-12-01 11:30 caseydk Note Added: 0000617
2009-12-02 16:37 caseydk Status new => resolved
2009-12-02 16:37 caseydk Resolution open => fixed
2009-12-02 16:37 caseydk Assigned To => caseydk
2009-12-02 16:37 caseydk Note Added: 0000618
2009-12-02 16:37 caseydk Project v1.1 Release (Closed) => v1.2 Release (Closed)
2009-12-08 21:02 caseydk Status resolved => closed
2009-12-08 21:02 caseydk Fixed in Version => 1.2


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker