MantisBT - v4.0 Release (Planning)
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000178v4.0 Release (Planning)Core Infrastructurepublic2009-06-07 21:182016-12-29 10:16
Reportercaseydk 
Assigned Tocaseydk 
PrioritylowSeverityminorReproducibilityalways
StatusacknowledgedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version4.0Fixed in Version4.0 
Summary0000178: Convert to the PSR Coding Standard
DescriptionThis will be updated to respect the PSRs instead of PEAR.
Additional InformationThis used to be the PEAR coding standard but has now been changed to PSR as of March 2014.
TagsNo tags attached.
Relationships
Attached Files

Notes
(0001639)
Pierre   
2011-02-17 08:53   
I don't know if this is the right place to discuss this, but just seeing this standard suggests to place the opening brackets at the end of the line makes my stomach turn inside out. :-) (I fell either not do it or don't enforce it)
Personally I also don't like tab stops of 4, but prefer 2 since it separates it good enough while more code is visible. (here there must be some standard)

What I find more important is commenting code and the more the better. Being somewhat consistent to how variables are named, global and local. Use meaningful text for function and variables, not x71_d.
(0001643)
caseydk   
2011-02-17 09:44   
I use tab stops of 4 but since most editors will let you configure that one, it's not a huge problem.

PEAR is handy because most of the tools - including IDE's - know how to read the standard and comments that follow it. We get code completion, static analysis, etc almost for free.

Regardless, this is a long term plan and we're working under the basis of "if you touch something, clean it up." As long as it's more legible for the next guy, we win. :)
(0003271)
caseydk   
2014-03-27 09:46   
This has been updated to use the PSR standards, specifically PSR-1.
(0003636)
caseydk   
2014-08-29 22:53   
Done:
https://github.com/web2project/web2project/commit/d0d200d1cdc8871a710b0ac1a291918fef9e5364
(0003837)
caseydk   
2016-12-29 10:16   

I'm changing this issue to acknowledged.

While it's resolved in the v4.0 development branch. That is going to be reviewed commit by commit and merged into a new development branch over the next couple months.

Issue History
Date ModifiedUsernameFieldChange
2009-06-07 21:18caseydkNew Issue
2009-06-14 05:38caseydkPrioritynormal => low
2009-08-03 04:08caseydkProjectv1.1 Release (Closed) => Pending Requests
2009-12-08 11:50caseydkProjectPending Requests => v1.3 Release (Closed)
2010-01-18 12:55caseydkProjectv1.3 Release (Closed) => v2.0 Release (Closed)
2010-05-29 22:08caseydkProjectv2.0 Release (Closed) => Pending Requests
2010-06-11 06:01caseydkProjectPending Requests => v2.1 Release (Closed)
2010-09-04 22:26caseydkProjectv2.1 Release (Closed) => v2.4 Release (Closed)
2011-02-17 08:53PierreNote Added: 0001639
2011-02-17 09:44caseydkNote Added: 0001643
2011-06-07 22:21caseydkProjectv2.4 Release (Closed) => Pending Requests
2011-08-09 13:12caseydkProjectPending Requests => v4.0 Release (Planning)
2014-01-21 17:57caseydkTarget Version => 4.0
2014-03-13 22:20caseydkCategoryGeneral => Calendar
2014-03-13 22:20caseydkSummaryConvert to the PEAR Coding Standard => Convert to the PSR Coding Standard
2014-03-13 22:20caseydkDescription Updatedbug_revision_view_page.php?rev_id=6#r6
2014-03-13 22:20caseydkAdditional Information Updatedbug_revision_view_page.php?rev_id=8#r8
2014-03-27 09:46caseydkNote Added: 0003271
2014-08-16 18:59caseydkCategoryCalendar => Core Infrastructure
2014-08-29 22:53caseydkNote Added: 0003636
2014-08-29 22:53caseydkStatusnew => resolved
2014-08-29 22:53caseydkFixed in Version => 4.0
2014-08-29 22:53caseydkResolutionopen => fixed
2014-08-29 22:53caseydkAssigned To => caseydk
2016-12-29 10:16caseydkStatusresolved => acknowledged
2016-12-29 10:16caseydkNote Added: 0003837