MantisBT - v2.1 Release (Closed)
View Issue Details
0000401v2.1 Release (Closed)[All Projects] Generalpublic2010-04-01 10:272010-09-21 23:08
Reporterzbyszek 
Assigned Tocaseydk 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Versionv2.1 
Target VersionFixed in Versionv2.1 
Summary0000401: view previous file versions
DescriptionAfter the update still not working from seeing the previous version of the file. Also in version 1.3 as dotproject

TagsNo tags attached.
Attached Filespng dotproject 3.png (365,925) 1969-12-31 16:00
https://bugs.web2project.net/file_download.php?file_id=75&type=bug
? addedit.php (9,094) 1969-12-31 16:00
https://bugs.web2project.net/file_download.php?file_id=116&type=bug
png web2Project - 15.png (220,151) 1969-12-31 16:00
https://bugs.web2project.net/file_download.php?file_id=118&type=bug
png

png web2Project - 15a.png (209,804) 1969-12-31 16:00
https://bugs.web2project.net/file_download.php?file_id=119&type=bug
png

Notes
(0001120)
caseydk   
2010-07-07 14:54   
I've tracked this down to having two pieces:

* First, in the index_table.php file, this line:

if ($file_row['file_lastversion'] > 1) {

is accepting 1.01 as a valid number (true in this case) but not 2.00. Casting it to a float resolves this issue.

* Second, the storage of the multiple versions is incorrect. It appears that at present, a newly uploaded file simply replaces the older version. I suspect this is in the do_files_aed.php controller and/or the core files class.
(0001134)
zbyszek   
2010-07-17 23:56   
Problem solved in attached file to replace compatible with v. 2.0-rew. 1233
(0001135)
zbyszek   
2010-07-18 11:29   
ProjectDesigner correctly shows, the display of the remaining files to be improved (works only with versions of the files after uploading patches)
(0001136)
caseydk   
2010-07-18 19:21   
Thanks. I'll review this in the next few days.
(0001139)
zbyszek   
2010-07-21 12:10   
Keith only here should be improved in other places is everything correctly
(0001143)
caseydk   
2010-07-22 22:56   
Is line 173 the only change? There's no change after applying that update..
(0001144)
zbyszek   
2010-07-23 00:39   
(Last edited: 2010-07-23 00:54)
The update is to: replace your addedit.php in modules \\ files \\ ..

correct showing after applying the alteration in enclosed pictures

(0001145)
zbyszek   
2010-07-23 04:51   
The change relates to the file: modules/files/addedit.php2 Line 173
with <input type="hidden" name="file_id" value="<?php echo $file->file_id; ?>"
change to:
<input type="hidden" name="file_id" value="<?php echo $file_id; ?>" />
(0001172)
caseydk   
2010-08-02 22:53   
Resolved in r1283 though a bit different than described.

I tweaked it to *always* save a new version of the file, whether it's a new checkin or not. The newest version is always displayed and the older versions are still available.

While this has the potential to have huge numbers of older files sitting around, I believe that it's necessary for data validation/review purposes.

Issue History
2010-04-01 10:27zbyszekNew Issue
2010-04-01 10:27zbyszekFile Added: dotproject 3.png
2010-04-01 19:01caseydkCategory-- none specified -- => Files
2010-07-03 23:11caseydkProjectPending Requests => v2.0 Release (Closed)
2010-07-07 14:45caseydkProjectv2.0 Release (Closed) => v2.1 Release (Closed)
2010-07-07 14:54caseydkNote Added: 0001120
2010-07-07 14:55caseydkPrioritynormal => high
2010-07-07 14:55caseydkSeverityminor => major
2010-07-08 13:26caseydkProjectv2.1 Release (Closed) => v2.0 Release (Closed)
2010-07-17 23:56zbyszekNote Added: 0001134
2010-07-17 23:57zbyszekFile Added: addedit.php
2010-07-18 11:29zbyszekNote Added: 0001135
2010-07-18 19:21caseydkNote Added: 0001136
2010-07-18 19:22caseydkStatusnew => assigned
2010-07-18 19:22caseydkAssigned To => caseydk
2010-07-21 11:49zbyszekFile Added: web2Project - 15ba.png
2010-07-21 12:10zbyszekNote Added: 0001139
2010-07-21 19:45caseydkFile Deleted: web2Project - 15ba.png
2010-07-22 22:56caseydkNote Added: 0001143
2010-07-23 00:39zbyszekNote Added: 0001144
2010-07-23 00:54zbyszekNote Edited: 0001144
2010-07-23 00:58zbyszekFile Added: web2Project - 15.png
2010-07-23 00:59zbyszekFile Added: web2Project - 15a.png
2010-07-23 04:51zbyszekNote Added: 0001145
2010-08-02 22:53caseydkNote Added: 0001172
2010-08-02 22:53caseydkStatusassigned => resolved
2010-08-02 22:53caseydkResolutionopen => fixed
2010-08-24 14:58caseydkProjectv2.0 Release (Closed) => v2.1 Release (Closed)
2010-09-21 22:11caseydkStatusresolved => closed
2010-09-21 22:39caseydkStatusclosed => resolved
2010-09-21 22:51caseydkStatusresolved => closed
2010-09-21 22:51caseydkFixed in Version => v2.1
2010-09-21 23:08caseydkProduct Version => v2.1