|
Notes |
|
|
(0001242)
|
|
opto
|
2010-08-29 01:46
(Last edited: 2010-08-29 01:50) |
|
in system config, it is the field TaskPriority
further down in same file, priority names are hardcoded:
$priorities = array('1' => 'high', '0' => 'normal', '-1' => 'low');
replace by
$priorities = w2PgetSysval('TaskPriority');
|
|
|
|
(0001244)
|
|
opto
|
|
2010-08-29 12:26
|
|
other place: hardcoded:
if ($task_priority == 'c') {
// mark task as completed
$q = new DBQuery;
$q->addTable('tasks');
$q->addUpdate('task_percent_complete', '100');
$q->addWhere('task_id=' . (int)$val);
} else
if ($task_priority == 'd') {
// delete task
$q = new DBQuery;
$q->setDelete('tasks');
$q->addWhere('task_id=' . (int)$val);
} else
if ($task_priority > -2 && $task_priority < 2) {
the last line should not be hardcoded (-2, 2)
$task_priority is a POST. So can it be other than what we offer in the select box? So is the 'if' necessary? Or just test on numeric?
For testing, I will comment it away so that higher priorities will be saved as well |
|
|
|
|
|
|
|
|
I'm changing this issue to acknowledged.
While it's resolved in the v4.0 development branch. That is going to be reviewed commit by commit and merged into a new development branch over the next couple months. |
|