MantisBT - v2.3 Release (Closed)
View Issue Details
0000642v2.3 Release (Closed)[All Projects] Generalpublic2010-11-25 00:522011-03-24 09:49
Reporterpaul_rogers6 
Assigned Tocaseydk 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version2.3 
Summary0000642: Reminders - multiple emails sent to one assignee
DescriptionWhere a task's owner is also an assignee the user in question receives two emails with the same reminder.
Additional InformationThis is because the code in the modules/tasks/tasks.class.php/remind() function is not correctly identifying if an assignee is also the owner. Line 2126 (v2.1.0) should be changed from:

$contacts = $q->loadHashList('c.contact_id');

to:

$contacts = $q->loadHashList('contact_id');

The amended file is attached (NB: Also contains updates for 0635).
TagsNo tags attached.
Attached Files? tasks.class.php (102,422) 1969-12-31 16:00
https://bugs.web2project.net/file_download.php?file_id=153&type=bug
? tasks.class.php.latest (102,451) 1969-12-31 16:00
https://bugs.web2project.net/file_download.php?file_id=155&type=bug

Notes
(0001363)
paul_rogers6   
2010-11-25 01:08   
NB: The statement:

The amended file is attached (NB: Also contains updates for 0635).

should read

The amended file is attached (NB: Also contains updates for 0623).

ie Updates also included for issue 623 NOT 635

Sorry

P
(0001368)
paul_rogers6   
2010-11-25 04:05   
(Last edited: 2010-11-25 04:10)
Have discovered another problem. As is remind function doesn't list owner as assignee if necessary. To fix this amend line 2177 (v2.1.0) from:

if ($owner_is_not_assignee || $contact['contact_id'] != $owner_contact) {

to:

if (!$owner_is_not_assignee || ($owner_is_not_assignee && $contact['contact_id'] != $owner_contact)) {

Have uploaded amended file modules/tasks/tasks.class.php (with changes for 0000623)

NB: Uploaded as tasks.class.php.latest to avoid duplicate file error

(0001750)
caseydk   
2011-03-22 23:51   
Resolved in r1765
(0001765)
caseydk   
2011-03-24 09:49   
Closed in preparation for v2.3 release.

Issue History
2010-11-25 00:52paul_rogers6New Issue
2010-11-25 00:52paul_rogers6File Added: tasks.class.php
2010-11-25 01:08paul_rogers6Note Added: 0001363
2010-11-25 04:05paul_rogers6Note Added: 0001368
2010-11-25 04:10paul_rogers6Note Edited: 0001368
2010-11-25 04:11paul_rogers6File Added: tasks.class.php.latest
2010-12-03 10:33caseydkProjectv2.0 Release (Closed) => v2.2 Release (Closed)
2010-12-15 21:54caseydkProjectv2.2 Release (Closed) => v2.3 Release (Closed)
2011-03-22 23:51caseydkNote Added: 0001750
2011-03-22 23:51caseydkStatusnew => resolved
2011-03-22 23:51caseydkResolutionopen => fixed
2011-03-22 23:51caseydkAssigned To => caseydk
2011-03-24 09:49caseydkNote Added: 0001765
2011-03-24 09:49caseydkStatusresolved => closed
2011-03-24 09:49caseydkFixed in Version => 2.3