|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0001238||Third-party Modules||Holidays||public||2013-01-02 03:11||2014-04-05 17:46|
|Target Version||Fixed in Version|
|Summary||0001238: Public Holidays are not found correctly if there is a year change between start date and end date|
|Description||January, 1st 2013 is not marked as a public holiday in the timecard module in weekly view. Analyzing the cause for this behavior directed me to the holiday module. In the file holiday_functions.class.php there is the function 'getHolidaysForDatespan' as cause for the faulty behavior.|
In case of a week starting in 2012, only public holidays in 2012 are found as a result of line 255 in holiday_function.class.php. January 1st, 2013 is therefor not marked as a public holiday.
As a first fix, i commented line 255, but I'm not sure, why this line is there in first place. I couldn't find any bad behavior caused by this change, but a correct solution might by different.
|Tags||No tags attached.|
|2013-01-02 03:11||karstenmtr||New Issue|
|2014-04-05 17:46||caseydk||Category||General => Holidays|