| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 0001661 | v3.5 Release (Development) | [All Projects] General | public | 2015-08-09 04:01 | 2019-01-01 16:15 | ||||||||
| Reporter | opto | ||||||||||||
| Assigned To | |||||||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||||||
| Status | new | Resolution | open | ||||||||||
| Summary | 0001661: logic broken for Ctasks::$this->importing_tasks? | ||||||||||||
| Description | the post create hook sets importing_tasks to true if parent !=0, feels not Logical: if ($this->task_parent) { // importing tasks do not update dynamics $this->importing_tasks = true; } we intentionally set parent to 0 in bulktasks important. so probably should be: if (!$this->task_parent) { why does preStore have this: $this->importing_tasks = false;?? Shouldn't/couldn't we remove all These and have bulktasks:importtask have set $this->importing_tasks to true before each Initial store? That is the place where we really know whether we are importing or not. Currently, we try to deduce from the parent id instead. | ||||||||||||
| Tags | No tags attached. | ||||||||||||
| Attached Files |
| ||||||||||||
 Relationships |
|
 Relationships |
| Notes |
|
| There are no notes attached to this issue. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-08-09 04:01 | opto | New Issue | |
| 2016-12-26 23:34 | caseydk | Project | v3.3 Release => v3.4 Release (Current) |
| 2019-01-01 16:15 | caseydk | Project | v3.4 Release (Current) => v3.5 Release (Development) |
| 2019-01-01 16:15 | caseydk | Category | Tasks => General |
| Issue History |